merging max_attempts or duration_seconds configs across files with invalid values will silently default to 0

[lucix-aws]

Describe the bug

This is going to be addressed by #2286 but I'm creating it for visibility.

If you specify multiple config files when loading shared config, "numeric" keys will silently default to 0 if a profile merge occurs from a source where one of those values are not a valid number.

At this time this only affects two fields:

• max_attempts
• duration_seconds

Expected Behavior

Shared config recognizes the invalid value and returns an error.

Current Behavior

Silently defaults to the zero value.

Reproduction Steps

Create two config files:

[default]
max_attempts=54

[default]
region=us-east-2
max_attempts=invalid

func main() {
    cfg, err := config.LoadDefaultConfig(context.Background(), func(o *config.LoadOptions) error {
        o.SharedConfigFiles = []string{
            "/Users/lucix/.aws/config",
            "/Users/lucix/.aws/config2",
        }
        return nil
    })
    if err != nil {
        log.Fatal(err)
    }

    dynamodb.NewFromConfig(cfg, func(o *dynamodb.Options) {
        fmt.Println(o.Region)
        fmt.Println(o.RetryMaxAttempts)
    })
}

This will output

us-east-2
0

We should see an error when attempting to load the value for RetryMaxAttempts.

Possible Solution

No response

Additional Information/Context

No response

AWS Go SDK V2 Module Versions Used

latest

Compiler and Version used

latest

Operating System and version

n/a

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.