internal/awstesting: Update SDK custom certificate testing utils #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the SDK's custom certificate testing utilities to be compatible with Go 1.18's deprecating of SHA1. Switch from static openssl generated certificates to generate certificates at package initialization. Related to aws/aws-sdk-go#4316
skmcgrail
reviewed
Mar 17, 2022
|
|
||
| // CreateClientTLSCertFiles returns a set of temporary files for the client | ||
| // certificate and key files. | ||
| func CreateClientTLSCertFiles() (cert, key string, err error) { |
There was a problem hiding this comment.
Do these actually need to be written out to disk?
There was a problem hiding this comment.
For the v1 SDK yes since it supports the AWS_SDK_GO_CLIENT_TLS_KEY environment variables. Though it doesn't look like the v2 SDK has this behavior for some reason. Will have to investigate why that is missing.
skmcgrail
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the SDK's custom certificate testing utilities to be compatible
with Go 1.18's deprecating of SHA1. Switch from static openssl generated
certificates to generate certificates at package initialization.
Related to aws/aws-sdk-go#4316