move transfer manager v2 integration tests to within module #2987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wty-Bryant
approved these changes
Jan 28, 2025
Madrigal
approved these changes
Jan 28, 2025
| @@ -257,3 +266,159 @@ func testPutObject(t *testing.T, bucket string, testData putObjectTestData, opts | |||
| t.Errorf("expect %s, got %s", e, a) | |||
| } | |||
| } | |||
|
|
|||
| const expressAZID = "usw2-az3" | |||
There was a problem hiding this comment.
should we TODO to move these back to shared once we merge this back into main?
There was a problem hiding this comment.
yes, I'll let CI pass and then put that in
| @@ -1,7 +1,7 @@ | |||
| //go:build integration | |||
| // +build integration | |||
|
|
|||
| package s3transfermanager | |||
| package transfermanager | |||
There was a problem hiding this comment.
is the rename required or just something we prefer?
There was a problem hiding this comment.
required, this package is transfermanager
lucix-aws
added a commit
that referenced
this pull request
Jan 28, 2025
wty-Bryant
pushed a commit
that referenced
this pull request
Jan 30, 2025
move transfer manager v2 integration tests to within module
wty-Bryant
pushed a commit
that referenced
this pull request
Jan 31, 2025
move transfer manager v2 integration tests to within module move putobject integ test to transfer manager module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As written, the
service/internal/integrationtestpackage depends on the s3 transfer manager module for its newly-added integration tests (as it should) - but our release tooling won't let us disable releases for any module that other things depend on. Since we need to putfeature/s3/transfermanagerinto main, with releases disabled (to cut beta tags) - we need to remove that dependency.Integration tests still work: