Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throttled Retries not capped at ~5mins #1653

Closed
fly1028 opened this issue Nov 19, 2017 · 3 comments · Fixed by #1654 or #1656
Closed

Throttled Retries not capped at ~5mins #1653

fly1028 opened this issue Nov 19, 2017 · 3 comments · Fixed by #1654 or #1656
Labels
bug This issue is a bug. guidance Question that needs advice or information.

Comments

@fly1028
Copy link

fly1028 commented Nov 19, 2017

} else if throttle && retryCount > 8 {

When Request.RetryCount=14, the first "if" condition applies and set the retryCount to 13.
The next retry is more than one hour later.

See
https://play.golang.org/p/vzNJVpLGHZ

@xibz
Copy link
Contributor

xibz commented Nov 19, 2017

Hello @fly1028, thank you for reaching out to us. Normal retries are capped at roughly ~5minutes. And it looks like throttles ~5 minutes.

Please see my example

edit: nvm, there is an issue with the if statement not looking that it is throttled first.

@xibz xibz added guidance Question that needs advice or information. bug This issue is a bug. labels Nov 19, 2017
@xibz
Copy link
Contributor

xibz commented Nov 19, 2017

Thanks for finding this @fly1028. I have a PR, #1654, for this. Please let us know if you have any other issues with this!

@fly1028
Copy link
Author

fly1028 commented Nov 19, 2017

Thank you @xibz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. guidance Question that needs advice or information.
Projects
None yet
2 participants