Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws/client: fixing bug where throttled retry's math was off #1654

Merged
merged 1 commit into from
Nov 20, 2017
Merged

aws/client: fixing bug where throttled retry's math was off #1654

merged 1 commit into from
Nov 20, 2017

Conversation

xibz
Copy link
Contributor

@xibz xibz commented Nov 19, 2017 •
edited
Loading

fixes #1653

@xibz xibz requested a review from jasdel November 19, 2017 03:50
@xibz xibz mentioned this pull request Nov 19, 2017
Closed
jasdel
jasdel approved these changes Nov 20, 2017
View reviewed changes
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just nit with pending change log.

CHANGELOG_PENDING.md Outdated
@@ -3,3 +3,5 @@
### SDK Enhancements

### SDK Bugs
* `aws/client`: Retry delays for throttled exception were not limited to 5 mintues (([#1654](https://github.com/aws/aws-sdk-go/pull/1654))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit extra ( in Pr link

CHANGELOG_PENDING.md Outdated
@@ -3,3 +3,5 @@
### SDK Enhancements

### SDK Bugs
* `aws/client`: Retry delays for throttled exception were not limited to 5 mintues (([#1654](https://github.com/aws/aws-sdk-go/pull/1654))
* Fixes [#1653]((https://github.com/aws/aws-sdk-go/issues/1653))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, extra ( and ) here

@xibz xibz merged commit 4bd6f8b into aws:master Nov 20, 2017
@xibz xibz mentioned this pull request Nov 20, 2017
Closed
@awstools awstools mentioned this pull request Nov 20, 2017
Merged
@bflad bflad mentioned this pull request Nov 22, 2017
Closed
@xibz xibz deleted the bug_1653 branch March 8, 2018 05:59
@skotambkar skotambkar mentioned this pull request Aug 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasdel jasdel jasdel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Throttled Retries not capped at ~5mins
2 participants
@xibz @jasdel