Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: add SharedConfigFiles option #1268

Merged
merged 1 commit into from
May 12, 2017
Merged

session: add SharedConfigFiles option #1268

merged 1 commit into from
May 12, 2017

Conversation

hongchaodeng
Copy link
Contributor

Add SharedConfigFiles option for users to load custom config files.
This will override any related ENV.

Fix #1258

@jasdel
Copy link
Contributor

jasdel commented May 12, 2017

Thanks for creating this PR, the change looks good. Would you mind adding a test to session_test.go that validates this change.

@jasdel jasdel self-requested a review May 12, 2017 17:25
@hongchaodeng
session: add SharedConfigFiles option
5c396a4 
Add SharedConfigFiles option for users to load custom config files.
This will override any related ENV.
@hongchaodeng
Copy link
Contributor Author

Test added. PTAL

jasdel
jasdel approved these changes May 12, 2017
View reviewed changes
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test, and creating this PR. The change looks good.

@jasdel jasdel merged commit 1c045ec into aws:master May 12, 2017
@hongchaodeng hongchaodeng deleted the cf branch May 12, 2017 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasdel jasdel jasdel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hongchaodeng @jasdel