aws/defaults: Export Shared Config/Creds filename helpers #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
force-pushed
the
fixup/ExportSharedConfigFilepath
branch
2 times, most recently
from
108851e to
94364b6
Compare
xibz
suggested changes
May 31, 2017
awstesting/util.go
Outdated
|
|
||
| for _, e := range env { | ||
| p := strings.SplitN(e, "=", 2) | ||
| os.Setenv(p[0], p[1]) |
There was a problem hiding this comment.
This could panic for someone that passed in an invalid string. Should we document that or check for length?
There was a problem hiding this comment.
good point, i'll add validation of the length.
jasdel
force-pushed
the
fixup/ExportSharedConfigFilepath
branch
from
94364b6 to
9890f9d
Compare
jasdel
added a commit
to jasdel/aws-sdk-go
that referenced
this pull request
Jun 1, 2017
In aws#1308 the filename was being retrieved with the SharedConfigFilename utility function not SharedCredentialsFilename function.
jasdel
added a commit
that referenced
this pull request
Jun 1, 2017
Merged
jasdel
added a commit
that referenced
this pull request
Jun 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exports the shared credentials and shared config filename helper functions to make it easier to get the filename of the credentials and config file.
Corrects a bug in the shared credentials and config HOME path that would return an invalid filename on windows if the
HOMEenvironment variable was defined.Replaces #1293