Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws/arn: Package for parsing and producing ARNs #1463

Merged
merged 1 commit into from
Aug 15, 2017
Merged

Conversation

samuelkarp
Copy link
Contributor

This package allows for parsing and producing Amazon Resource Names (ARNs). ARNs are parsed in accordance with the documentation.

This package avoids parsing the Resource section of the ARN, as that can vary widely by AWS service.

@jasdel
Copy link
Contributor

jasdel commented Aug 11, 2017

Thanks! Would you mind adding a // +build go1.7 build tag to the top of the test file so the t.Run call can stay in. This should let the test succeed for Go 1.6 and 1.5.

@samuelkarp samuelkarp force-pushed the arn branch 2 times, most recently from cc8fca7 to 15bbb4d Compare August 11, 2017 17:48
@samuelkarp
Copy link
Contributor Author

@jasdel Done

@jasdel jasdel merged commit 1fb10cf into aws:master Aug 15, 2017
jasdel added a commit that referenced this pull request Aug 15, 2017
@awstools awstools mentioned this pull request Aug 16, 2017
stack72 added a commit to stack72/terraform-provider-aws that referenced this pull request Aug 21, 2017
This now includes a package to help build ARNs. This will mean that a
lot of old Terraform code that manually create ARNs can be replaced:

aws/aws-sdk-go#1463
nbaztec pushed a commit to nbaztec/terraform-provider-aws that referenced this pull request Sep 26, 2017
This now includes a package to help build ARNs. This will mean that a
lot of old Terraform code that manually create ARNs can be replaced:

aws/aws-sdk-go#1463
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants