Add s3.HostedZoneIDForRegion #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justincampbell
force-pushed
the
hosted-zone-map
branch
from
74eff1d to
c8506cd
Compare
Needed to support hashicorp/terraform#1769
justincampbell
force-pushed
the
hosted-zone-map
branch
from
c8506cd to
70a1b5d
Compare
justincampbell
changed the title
|
Hi @justincampbell thanks for the PR. For now we would like to hold off including the Zone ID to Region mapping directly in the SDK. We currently do not have a good method of generating this mapping to ensure the list doesn't become outdated, which is inline with the other AWS SDKs. |
|
Understood, thanks! |
skotambkar
pushed a commit
to skotambkar/aws-sdk-go
that referenced
this pull request
May 20, 2021
There was a missing import to make the README tutorial compile properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to support hashicorp/terraform#1769
I didn't see a way to automatically generate this. Please let me know if that's a possibility, or if there's a better location to place this.