aws/session: Fix formatting bug in doc. #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a minor issue in `aws/session/doc.go` where the developer mistakenly used format specifiers in `logger.Println`. Changes committed: modified: aws/session/doc.go Signed-off-by: Abhishek Kashyap <avskksyp@gmail.com>
jasdel
approved these changes
Nov 22, 2018
|
Hey @jasdel , What is it which is keeping us from merging this PR? |
|
Hi @a4abhishek thanks for creating the fix for this documentation. The change is good and we'll be able to merge it. We're holding off merging non-critical updates during re:Invent. We'll be be able to merge in this change after re:Invent at the latest. |
|
Sure @jasdel , thanks. |
jasdel
changed the title
aws/session
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a minor issue in
aws/session/doc.gowhere the developer mistakenly used format specifiers inlogger.Println.Changes committed:
modified: aws/session/doc.go
Signed-off-by: Abhishek Kashyap avskksyp@gmail.com