Fixup SDK's vet usage to use go vet with build tags #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the SDK's usage of vet to use go vet instead of go tool vet. This allows the SDK to pass build tags and packages instead of just folder paths to the tool. Fixes SDK's CI test failure with Go Tip.
JordonPhillips
suggested changes
Nov 26, 2018
There was a problem hiding this comment.
Running make vet now modifies source:
diff --git a/go.mod b/go.mod
index 7a1bd6e9..7591dced 100644
--- a/go.mod
+++ b/go.mod
@@ -1,5 +1,10 @@
module github.com/aws/aws-sdk-go
require (
+ github.com/davecgh/go-spew v1.1.1 // indirect
github.com/jmespath/go-jmespath v0.0.0-20160202185014-0b12d6b521d8
+ github.com/pmezard/go-difflib v1.0.0 // indirect
+ github.com/stretchr/testify v1.2.2
+ golang.org/x/net v0.0.0-20181114220301-adae6a3d119a
+ golang.org/x/text v0.3.0 // indirect
)
diff --git a/go.sum b/go.sum
index be7628e2..417fa5dd 100644
--- a/go.sum
+++ b/go.sum
@@ -1 +1,12 @@
+github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
+github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
+github.com/jmespath/go-jmespath v0.0.0-20160202185014-0b12d6b521d8 h1:12VvqtR6Aowv3l/EQUlocDHW2Cp4G9WJVH7uyH8QFJE=
github.com/jmespath/go-jmespath v0.0.0-20160202185014-0b12d6b521d8/go.mod h1:Nht3zPeWKUH0NzdCt2Blrr5ys8VGpn0CEB0cQHVjt7k=
+github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
+github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
+github.com/stretchr/testify v1.2.2 h1:bSDNvY7ZPG5RlJ8otE/7V6gMiyenm9RtJ7IUVIAoJ1w=
+github.com/stretchr/testify v1.2.2/go.mod h1:a8OnRcib4nhh0OaRAV+Yts87kKdq0PP7pXfy6kDkUVs=
+golang.org/x/net v0.0.0-20181114220301-adae6a3d119a h1:gOpx8G595UYyvj8UK4+OFyY4rx037g3fmfhe5SasG3U=
+golang.org/x/net v0.0.0-20181114220301-adae6a3d119a/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
+golang.org/x/text v0.3.0 h1:g61tztE5qeGQ89tm6NTjjM9VPIm088od1l6aSorWRWg=
+golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
|
Yeah :/ running any go command will update the Though it does look like the |
xibz
reviewed
Dec 3, 2018
| @@ -1,34 +0,0 @@ | |||
| // +build integration | |||
There was a problem hiding this comment.
Why is this test getting removed?
There was a problem hiding this comment.
This test never actually was used, and did not compile. The SDK's make integration cmd never executed this unit since it was in the service folder. The test looks to exist in order to test the flatten modeled trait, but this is tested via the SDK's protocol tests.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the SDK's usage of vet to use go vet instead of go tool vet.
This allows the SDK to pass build tags and packages instead of just
folder paths to the tool.
Fixes SDK's CI test failure with Go Tip.
Removes invalid SQS API integration test that was not being used.