aws/ec2metadata: Fix EC2 Metadata client panic with debug logging #2461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a panic that could occur witihin the EC2 Metadata client when both `AWS_EC2_METADATA_DISABLED` env var is set and log level is LogDebugWithHTTPBody. The SDK's client response body debug functionality would panic because the Request.HTTPResponse value was not specified. Updates the client debug loggers to check if the response is set before attempting to log.
Merged
jasdel
added a commit
to jasdel/aws-sdk-go-v2
that referenced
this pull request
Apr 9, 2019
Fixes a panic that could occur witihin the EC2 Metadata client when both AWS_EC2_METADATA_DISABLED env var is set and log level is LogDebugWithHTTPBody. The SDK's client response body debug functionality would panic because the Request.HTTPResponse value was not specified. Updates the client debug loggers to check if the response is set before attempting to log. V2 SDK port of: aws/aws-sdk-go#2461
jasdel
added a commit
to aws/aws-sdk-go-v2
that referenced
this pull request
Apr 10, 2019
Fixes a panic that could occur witihin the EC2 Metadata client when both AWS_EC2_METADATA_DISABLED env var is set and log level is LogDebugWithHTTPBody. The SDK's client response body debug functionality would panic because the Request.HTTPResponse value was not specified. Updates the client debug loggers to check if the response is set before attempting to log. V2 SDK port of: aws/aws-sdk-go#2461
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a panic that could occur witihin the EC2 Metadata client when both
AWS_EC2_METADATA_DISABLEDenv var is set and log level isLogDebugWithHTTPBody. The SDK's client response body debug functionality
would panic because the Request.HTTPResponse value was not specified.
Updates the client debug loggers to check if the response is set before
attempting to log.