Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add jitter to AssumeRoleProvider #2551

Merged
merged 4 commits into from Apr 24, 2019
Merged

add jitter to AssumeRoleProvider #2551

merged 4 commits into from Apr 24, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 5, 2019

This adds jitter to the AssumeRoleProvider which backs stscreds.NewCredentials. This helps to support large deployments.

jasdel
jasdel approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to create this change. The change looks good and we'll merge it in and have it included in our next release.

jasdel
jasdel suggested changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a small issue in the CI tests that will fix the unit test failing.

aws/credentials/stscreds/assume_role_provider.go Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Apr 5, 2019

There are two linker failures.

@jasdel
Copy link
Contributor

jasdel commented Apr 8, 2019

I think the linker failures are due to, golang/go#31293

PLR and others added 2 commits April 9, 2019 13:41
specify jitter as a fraction of the total
ce65593
@jasdel
Update MaxJitterFrac doc
dd6aef0 
Update the documentation for MaxJitterFrac to emphasize the value must be between 0 and 1.
jasdel
jasdel approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for making this update. I tweeked the wording a little bit on MaxJitterFrac to highlyt the requirement that the value be between 0 and 1.

@ghost
Copy link
Author

ghost commented Apr 9, 2019

Ah, thanks for catching that omission. Yeah, hopefully this way of representing the jitter amount will cause folks less headaches when they change the Duration parameter.

@jasdel jasdel merged commit c2180da into aws:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jasdel