service/kinesis: Add support for retrying service specific API errors #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for retrying the Kinesis API error, "LimitExceededException". Fix aws#1376
jasdel
added
the
needs-review
skotambkar
approved these changes
Aug 14, 2019
Merged
bflad
added a commit
to hashicorp/terraform-provider-aws
that referenced
this pull request
Aug 30, 2019
The AWS Go SDK now automatically retries on this error. References: - aws/aws-sdk-go#1376 - #1085 - aws/aws-sdk-go#2751 - #9770 Output from acceptance testing: ``` --- PASS: TestAccAWSKinesisStream_createMultipleConcurrentStreams (205.83s) ```
skotambkar
added a commit
to aws/aws-sdk-go-v2
that referenced
this pull request
Sep 17, 2019
Ports v1 SDK's retry utilities to follow a consistent code path. aws.IsErrorRetryable is the primary entry point to determine if a request is retryable. Also ports support for service/kinesis to retry service specific API errors . Corrects sdk's behavior by not retrying errors with status code 501. Related to aws/aws-sdk-go#2744, aws/aws-sdk-go#2774, aws/aws-sdk-go#2751 and aws/aws-sdk-go#1826 Fixes #372; Fixes #145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for retrying the Kinesis API error,
LimitExceededException.Fix #1376