-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix-resolve-home-v1 #4519
Merged
Merged
fix-resolve-home-v1 #4519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
suggested changes
Aug 15, 2022
skmcgrail
approved these changes
Oct 18, 2022
skmcgrail
approved these changes
Oct 18, 2022
grrtrr
reviewed
Oct 18, 2022
) | ||
|
||
func userHomeDir() string { | ||
home, _ := os.UserHomeDir() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not fix the problem with #4444, since os.UserHomeDir
is also based on $HOME
.
Test program to demonstrate:
// go build test.go
// env -i ./test
package main
import (
"fmt"
"os"
)
func main() {
home, err := os.UserHomeDir()
fmt.Println(home, err) // prints "$HOME not defined" if variable is empty
}
Better solution:
package main
import (
"fmt"
"os/user"
)
func main() {
user, err := user.Current()
fmt.Println(user.HomeDir, err) // Prints home directory even when running under env -i or $HOME unset.
}
The user.Current()
is based on getpwent
and thus is independent of the $HOME
variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For changes to files under the
/model/
folder, and manual edits to autogenerated code (e.g./service/s3/api.go
) please create an Issue instead of a PR for those type of changes.If there is an existing bug or feature this PR is answers please reference it here.
#4444
Added a fallback to resolve home using current user from "os/user".