don't generate cloudwatchlogs event streams tests for now #5071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wty-Bryant
approved these changes
Nov 15, 2023
| @@ -180,7 +182,10 @@ func writeServiceFiles(g *generateInfo, pkgDir string) { | |||
| Must(writeExamplesFile(g)) | |||
|
|
|||
| if g.API.HasEventStream { | |||
| Must(writeAPIEventStreamTestFile(g)) | |||
| // has stream APIs with host prefix, which our tests break on, skip codegen for now | |||
| if g.API.PackageName() != "cloudwatchlogs" { | |||
There was a problem hiding this comment.
nit: why not combine 2 if judgement together like this
if g.API.HasEventStream && g.API.PackageName() != "cloudwatchlogs"
There was a problem hiding this comment.
at first glance we should not hard code the cloudwatchlogs and its tests, but this is the best solution up to now
There was a problem hiding this comment.
Mostly just to isolate the cloudwatch check so it's minimally less effort to rip out if we ever fix this (or extend it if we have to)
isaiahvita
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.