Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save sso cache token expiresAt in UTC #5293

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

clhuang
Copy link

@clhuang clhuang commented Jun 23, 2024

If the expiresAt field is saved with time zone (e.g. 2024-06-10T15:00:06-08:00) it will fail to load in certain SDKs such as the rust AWS SDK. To avoid this, ensure that it is always saved as a UTC format.

[IMPORTANT] We announced the upcoming end-of-support for AWS SDK for Go v1. We are no longer accepting PRs for additive features to the v1 SDK.

For changes to files under the /model/ folder, and manual edits to autogenerated code (e.g. /service/s3/api.go) please create an Issue instead of a PR for those type of changes.

If there is an existing bug or feature this PR is answers please reference it here.

If the expiresAt field is saved with time zone (e.g. `2024-06-10T15:00:06-08:00`) it will fail to load in certain SDKs such as the rust AWS SDK. To avoid this, ensure that it is always saved as a UTC format.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant