Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to verify that type is ignored in union types during deseri… #4457

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Add tests to verify that type is ignored in union types during deseri… #4457

merged 1 commit into from
Sep 21, 2023

Conversation

zoewangg
Copy link
Contributor

…alization

Motivation and Context

smithy-lang/smithy#1945

Modifications

The SDK ignores unknown fields, so it's no-op. This PR just added protocol tests to verify it.

Testing

Added protocol tests

@zoewangg zoewangg requested a review from a team as a code owner September 20, 2023 23:13
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@zoewangg zoewangg merged commit 5ea3c40 into master Sep 21, 2023
@zoewangg zoewangg deleted the zoewang/unionTypeIgnoreTypeField branch September 21, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joviegas joviegas joviegas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zoewangg @joviegas