fix(codegen): consistently add region as config option when generated…

… client is Sigv4 but not AWS (#6156)

* fix(codegen): consistently add region as config option when generated client is Sigv4 but not AWS

* fix(codegen): consistently add region as config option when generated client is Sigv4 but not AWS

* fix(codegen): codegen diff

* fix(codegen): do not provide credentialDefaultProvider if service is not sigv4

* fix(codegen): address pr comments

* chore(codegen): sync codegen

clients/client-accessanalyzer/src/AccessAnalyzerClient.ts

@@ -284,15 +284,15 @@ export interface ClientDefaults extends Partial<__SmithyConfiguration<__HttpHand
   useFipsEndpoint?: boolean | __Provider<boolean>;
 
   /**
-   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
-   * @internal
+   * The AWS region to which this client will send requests
    */
-  defaultUserAgentProvider?: Provider<__UserAgent>;
+  region?: string | __Provider<string>;
 
   /**
-   * The AWS region to which this client will send requests
+   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
+   * @internal
    */
-  region?: string | __Provider<string>;
+  defaultUserAgentProvider?: Provider<__UserAgent>;
 
   /**
    * Default credentials provider; Not available in browser runtime.

clients/client-account/src/AccountClient.ts

@@ -203,15 +203,15 @@ export interface ClientDefaults extends Partial<__SmithyConfiguration<__HttpHand
   useFipsEndpoint?: boolean | __Provider<boolean>;
 
   /**
-   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
-   * @internal
+   * The AWS region to which this client will send requests
    */
-  defaultUserAgentProvider?: Provider<__UserAgent>;
+  region?: string | __Provider<string>;
 
   /**
-   * The AWS region to which this client will send requests
+   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
+   * @internal
    */
-  region?: string | __Provider<string>;
+  defaultUserAgentProvider?: Provider<__UserAgent>;
 
   /**
    * Default credentials provider; Not available in browser runtime.

clients/client-acm-pca/src/ACMPCAClient.ts

@@ -269,15 +269,15 @@ export interface ClientDefaults extends Partial<__SmithyConfiguration<__HttpHand
   useFipsEndpoint?: boolean | __Provider<boolean>;
 
   /**
-   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
-   * @internal
+   * The AWS region to which this client will send requests
    */
-  defaultUserAgentProvider?: Provider<__UserAgent>;
+  region?: string | __Provider<string>;
 
   /**
-   * The AWS region to which this client will send requests
+   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
+   * @internal
    */
-  region?: string | __Provider<string>;
+  defaultUserAgentProvider?: Provider<__UserAgent>;
 
   /**
    * Default credentials provider; Not available in browser runtime.

clients/client-acm/src/ACMClient.ts

@@ -230,15 +230,15 @@ export interface ClientDefaults extends Partial<__SmithyConfiguration<__HttpHand
   useFipsEndpoint?: boolean | __Provider<boolean>;
 
   /**
-   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
-   * @internal
+   * The AWS region to which this client will send requests
    */
-  defaultUserAgentProvider?: Provider<__UserAgent>;
+  region?: string | __Provider<string>;
 
   /**
-   * The AWS region to which this client will send requests
+   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
+   * @internal
    */
-  region?: string | __Provider<string>;
+  defaultUserAgentProvider?: Provider<__UserAgent>;
 
   /**
    * Default credentials provider; Not available in browser runtime.

clients/client-amp/src/AmpClient.ts

@@ -287,15 +287,15 @@ export interface ClientDefaults extends Partial<__SmithyConfiguration<__HttpHand
   useFipsEndpoint?: boolean | __Provider<boolean>;
 
   /**
-   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
-   * @internal
+   * The AWS region to which this client will send requests
    */
-  defaultUserAgentProvider?: Provider<__UserAgent>;
+  region?: string | __Provider<string>;
 
   /**
-   * The AWS region to which this client will send requests
+   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
+   * @internal
    */
-  region?: string | __Provider<string>;
+  defaultUserAgentProvider?: Provider<__UserAgent>;
 
   /**
    * Default credentials provider; Not available in browser runtime.

clients/client-amplify/src/AmplifyClient.ts

@@ -302,15 +302,15 @@ export interface ClientDefaults extends Partial<__SmithyConfiguration<__HttpHand
   useFipsEndpoint?: boolean | __Provider<boolean>;
 
   /**
-   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
-   * @internal
+   * The AWS region to which this client will send requests
    */
-  defaultUserAgentProvider?: Provider<__UserAgent>;
+  region?: string | __Provider<string>;
 
   /**
-   * The AWS region to which this client will send requests
+   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
+   * @internal
    */
-  region?: string | __Provider<string>;
+  defaultUserAgentProvider?: Provider<__UserAgent>;
 
   /**
    * Default credentials provider; Not available in browser runtime.

clients/client-amplifybackend/src/AmplifyBackendClient.ts

@@ -281,15 +281,15 @@ export interface ClientDefaults extends Partial<__SmithyConfiguration<__HttpHand
   useFipsEndpoint?: boolean | __Provider<boolean>;
 
   /**
-   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
-   * @internal
+   * The AWS region to which this client will send requests
    */
-  defaultUserAgentProvider?: Provider<__UserAgent>;
+  region?: string | __Provider<string>;
 
   /**
-   * The AWS region to which this client will send requests
+   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
+   * @internal
    */
-  region?: string | __Provider<string>;
+  defaultUserAgentProvider?: Provider<__UserAgent>;
 
   /**
    * Default credentials provider; Not available in browser runtime.

clients/client-amplifyuibuilder/src/AmplifyUIBuilderClient.ts

@@ -251,15 +251,15 @@ export interface ClientDefaults extends Partial<__SmithyConfiguration<__HttpHand
   useFipsEndpoint?: boolean | __Provider<boolean>;
 
   /**
-   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
-   * @internal
+   * The AWS region to which this client will send requests
    */
-  defaultUserAgentProvider?: Provider<__UserAgent>;
+  region?: string | __Provider<string>;
 
   /**
-   * The AWS region to which this client will send requests
+   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
+   * @internal
    */
-  region?: string | __Provider<string>;
+  defaultUserAgentProvider?: Provider<__UserAgent>;
 
   /**
    * Default credentials provider; Not available in browser runtime.

clients/client-api-gateway/src/APIGatewayClient.ts

@@ -630,15 +630,15 @@ export interface ClientDefaults extends Partial<__SmithyConfiguration<__HttpHand
   useFipsEndpoint?: boolean | __Provider<boolean>;
 
   /**
-   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
-   * @internal
+   * The AWS region to which this client will send requests
    */
-  defaultUserAgentProvider?: Provider<__UserAgent>;
+  region?: string | __Provider<string>;
 
   /**
-   * The AWS region to which this client will send requests
+   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
+   * @internal
    */
-  region?: string | __Provider<string>;
+  defaultUserAgentProvider?: Provider<__UserAgent>;
 
   /**
    * Default credentials provider; Not available in browser runtime.

clients/client-apigatewaymanagementapi/src/ApiGatewayManagementApiClient.ts

@@ -167,15 +167,15 @@ export interface ClientDefaults extends Partial<__SmithyConfiguration<__HttpHand
   useFipsEndpoint?: boolean | __Provider<boolean>;
 
   /**
-   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
-   * @internal
+   * The AWS region to which this client will send requests
    */
-  defaultUserAgentProvider?: Provider<__UserAgent>;
+  region?: string | __Provider<string>;
 
   /**
-   * The AWS region to which this client will send requests
+   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
+   * @internal
    */
-  region?: string | __Provider<string>;
+  defaultUserAgentProvider?: Provider<__UserAgent>;
 
   /**
    * Default credentials provider; Not available in browser runtime.

clients/client-apigatewayv2/src/ApiGatewayV2Client.ts

@@ -416,15 +416,15 @@ export interface ClientDefaults extends Partial<__SmithyConfiguration<__HttpHand
   useFipsEndpoint?: boolean | __Provider<boolean>;
 
   /**
-   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
-   * @internal
+   * The AWS region to which this client will send requests
    */
-  defaultUserAgentProvider?: Provider<__UserAgent>;
+  region?: string | __Provider<string>;
 
   /**
-   * The AWS region to which this client will send requests
+   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
+   * @internal
    */
-  region?: string | __Provider<string>;
+  defaultUserAgentProvider?: Provider<__UserAgent>;
 
   /**
    * Default credentials provider; Not available in browser runtime.

clients/client-app-mesh/src/AppMeshClient.ts

@@ -326,15 +326,15 @@ export interface ClientDefaults extends Partial<__SmithyConfiguration<__HttpHand
   useFipsEndpoint?: boolean | __Provider<boolean>;
 
   /**
-   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
-   * @internal
+   * The AWS region to which this client will send requests
    */
-  defaultUserAgentProvider?: Provider<__UserAgent>;
+  region?: string | __Provider<string>;
 
   /**
-   * The AWS region to which this client will send requests
+   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
+   * @internal
    */
-  region?: string | __Provider<string>;
+  defaultUserAgentProvider?: Provider<__UserAgent>;
 
   /**
    * Default credentials provider; Not available in browser runtime.

clients/client-appconfig/src/AppConfigClient.ts

@@ -353,15 +353,15 @@ export interface ClientDefaults extends Partial<__SmithyConfiguration<__HttpHand
   useFipsEndpoint?: boolean | __Provider<boolean>;
 
   /**
-   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
-   * @internal
+   * The AWS region to which this client will send requests
    */
-  defaultUserAgentProvider?: Provider<__UserAgent>;
+  region?: string | __Provider<string>;
 
   /**
-   * The AWS region to which this client will send requests
+   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
+   * @internal
    */
-  region?: string | __Provider<string>;
+  defaultUserAgentProvider?: Provider<__UserAgent>;
 
   /**
    * Default credentials provider; Not available in browser runtime.

clients/client-appconfigdata/src/AppConfigDataClient.ts

@@ -169,15 +169,15 @@ export interface ClientDefaults extends Partial<__SmithyConfiguration<__HttpHand
   useFipsEndpoint?: boolean | __Provider<boolean>;
 
   /**
-   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
-   * @internal
+   * The AWS region to which this client will send requests
    */
-  defaultUserAgentProvider?: Provider<__UserAgent>;
+  region?: string | __Provider<string>;
 
   /**
-   * The AWS region to which this client will send requests
+   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
+   * @internal
    */
-  region?: string | __Provider<string>;
+  defaultUserAgentProvider?: Provider<__UserAgent>;
 
   /**
    * Default credentials provider; Not available in browser runtime.

clients/client-appfabric/src/AppFabricClient.ts

@@ -281,15 +281,15 @@ export interface ClientDefaults extends Partial<__SmithyConfiguration<__HttpHand
   useFipsEndpoint?: boolean | __Provider<boolean>;
 
   /**
-   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
-   * @internal
+   * The AWS region to which this client will send requests
    */
-  defaultUserAgentProvider?: Provider<__UserAgent>;
+  region?: string | __Provider<string>;
 
   /**
-   * The AWS region to which this client will send requests
+   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
+   * @internal
    */
-  region?: string | __Provider<string>;
+  defaultUserAgentProvider?: Provider<__UserAgent>;
 
   /**
    * Default credentials provider; Not available in browser runtime.

clients/client-appflow/src/AppflowClient.ts

@@ -272,15 +272,15 @@ export interface ClientDefaults extends Partial<__SmithyConfiguration<__HttpHand
   useFipsEndpoint?: boolean | __Provider<boolean>;
 
   /**
-   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
-   * @internal
+   * The AWS region to which this client will send requests
    */
-  defaultUserAgentProvider?: Provider<__UserAgent>;
+  region?: string | __Provider<string>;
 
   /**
-   * The AWS region to which this client will send requests
+   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
+   * @internal
    */
-  region?: string | __Provider<string>;
+  defaultUserAgentProvider?: Provider<__UserAgent>;
 
   /**
    * Default credentials provider; Not available in browser runtime.

clients/client-appintegrations/src/AppIntegrationsClient.ts

@@ -263,15 +263,15 @@ export interface ClientDefaults extends Partial<__SmithyConfiguration<__HttpHand
   useFipsEndpoint?: boolean | __Provider<boolean>;
 
   /**
-   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
-   * @internal
+   * The AWS region to which this client will send requests
    */
-  defaultUserAgentProvider?: Provider<__UserAgent>;
+  region?: string | __Provider<string>;
 
   /**
-   * The AWS region to which this client will send requests
+   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
+   * @internal
    */
-  region?: string | __Provider<string>;
+  defaultUserAgentProvider?: Provider<__UserAgent>;
 
   /**
    * Default credentials provider; Not available in browser runtime.

clients/client-application-auto-scaling/src/ApplicationAutoScalingClient.ts

@@ -227,15 +227,15 @@ export interface ClientDefaults extends Partial<__SmithyConfiguration<__HttpHand
   useFipsEndpoint?: boolean | __Provider<boolean>;
 
   /**
-   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
-   * @internal
+   * The AWS region to which this client will send requests
    */
-  defaultUserAgentProvider?: Provider<__UserAgent>;
+  region?: string | __Provider<string>;
 
   /**
-   * The AWS region to which this client will send requests
+   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
+   * @internal
    */
-  region?: string | __Provider<string>;
+  defaultUserAgentProvider?: Provider<__UserAgent>;
 
   /**
    * Default credentials provider; Not available in browser runtime.

clients/client-application-discovery-service/src/ApplicationDiscoveryServiceClient.ts

@@ -296,15 +296,15 @@ export interface ClientDefaults extends Partial<__SmithyConfiguration<__HttpHand
   useFipsEndpoint?: boolean | __Provider<boolean>;
 
   /**
-   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
-   * @internal
+   * The AWS region to which this client will send requests
    */
-  defaultUserAgentProvider?: Provider<__UserAgent>;
+  region?: string | __Provider<string>;
 
   /**
-   * The AWS region to which this client will send requests
+   * The provider populating default tracking information to be sent with `user-agent`, `x-amz-user-agent` header
+   * @internal
    */
-  region?: string | __Provider<string>;
+  defaultUserAgentProvider?: Provider<__UserAgent>;
 
   /**
    * Default credentials provider; Not available in browser runtime.