Skip to content

Commit

Permalink
chore(middleware-sdk-s3): update s3 status 200 error handling (#6232)
Browse files Browse the repository at this point in the history
* chore(middleware-sdk-s3): update s3 status 200 error handling

* fix(middleware-sdk-s3): only check tail bytes in s3-200-errors

* chore(middleware-sdk-s3): use splitStream utility function to inspect 200-error
  • Loading branch information
kuhe authored Jul 17, 2024
1 parent 9ca8bae commit 9119ae6
Show file tree
Hide file tree
Showing 61 changed files with 276 additions and 46 deletions.
2 changes: 2 additions & 0 deletions clients/client-s3/src/commands/AbortMultipartUploadCommand.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// smithy-typescript generated code
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
import { Command as $Command } from "@smithy/smithy-client";
Expand Down Expand Up @@ -164,6 +165,7 @@ export class AbortMultipartUploadCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
];
})
.s("AmazonS3", "AbortMultipartUpload", {})
Expand Down
2 changes: 2 additions & 0 deletions clients/client-s3/src/commands/CreateBucketCommand.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// smithy-typescript generated code
import { getLocationConstraintPlugin } from "@aws-sdk/middleware-location-constraint";
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
import { Command as $Command } from "@smithy/smithy-client";
Expand Down Expand Up @@ -272,6 +273,7 @@ export class CreateBucketCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
getLocationConstraintPlugin(config),
];
})
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// smithy-typescript generated code
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getSsecPlugin } from "@aws-sdk/middleware-ssec";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
Expand Down Expand Up @@ -358,6 +359,7 @@ export class CreateMultipartUploadCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
getSsecPlugin(config),
];
})
Expand Down
2 changes: 2 additions & 0 deletions clients/client-s3/src/commands/CreateSessionCommand.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// smithy-typescript generated code
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
import { Command as $Command } from "@smithy/smithy-client";
Expand Down Expand Up @@ -146,6 +147,7 @@ export class CreateSessionCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
];
})
.s("AmazonS3", "CreateSession", {})
Expand Down
2 changes: 2 additions & 0 deletions clients/client-s3/src/commands/DeleteObjectCommand.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// smithy-typescript generated code
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
import { Command as $Command } from "@smithy/smithy-client";
Expand Down Expand Up @@ -204,6 +205,7 @@ export class DeleteObjectCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
];
})
.s("AmazonS3", "DeleteObject", {})
Expand Down
2 changes: 2 additions & 0 deletions clients/client-s3/src/commands/DeleteObjectTaggingCommand.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// smithy-typescript generated code
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
import { Command as $Command } from "@smithy/smithy-client";
Expand Down Expand Up @@ -133,6 +134,7 @@ export class DeleteObjectTaggingCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
];
})
.s("AmazonS3", "DeleteObjectTagging", {})
Expand Down
2 changes: 2 additions & 0 deletions clients/client-s3/src/commands/DeleteObjectsCommand.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// smithy-typescript generated code
import { getFlexibleChecksumsPlugin } from "@aws-sdk/middleware-flexible-checksums";
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
import { Command as $Command } from "@smithy/smithy-client";
Expand Down Expand Up @@ -305,6 +306,7 @@ export class DeleteObjectsCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
getFlexibleChecksumsPlugin(config, {
input: this.input,
requestAlgorithmMember: "ChecksumAlgorithm",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// smithy-typescript generated code
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
import { Command as $Command } from "@smithy/smithy-client";
Expand Down Expand Up @@ -110,6 +111,7 @@ export class GetBucketAccelerateConfigurationCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
];
})
.s("AmazonS3", "GetBucketAccelerateConfiguration", {})
Expand Down
2 changes: 2 additions & 0 deletions clients/client-s3/src/commands/GetBucketAclCommand.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// smithy-typescript generated code
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
import { Command as $Command } from "@smithy/smithy-client";
Expand Down Expand Up @@ -118,6 +119,7 @@ export class GetBucketAclCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
];
})
.s("AmazonS3", "GetBucketAcl", {})
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// smithy-typescript generated code
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
import { Command as $Command } from "@smithy/smithy-client";
Expand Down Expand Up @@ -143,6 +144,7 @@ export class GetBucketAnalyticsConfigurationCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
];
})
.s("AmazonS3", "GetBucketAnalyticsConfiguration", {})
Expand Down
2 changes: 2 additions & 0 deletions clients/client-s3/src/commands/GetBucketCorsCommand.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// smithy-typescript generated code
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
import { Command as $Command } from "@smithy/smithy-client";
Expand Down Expand Up @@ -148,6 +149,7 @@ export class GetBucketCorsCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
];
})
.s("AmazonS3", "GetBucketCors", {})
Expand Down
2 changes: 2 additions & 0 deletions clients/client-s3/src/commands/GetBucketEncryptionCommand.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// smithy-typescript generated code
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
import { Command as $Command } from "@smithy/smithy-client";
Expand Down Expand Up @@ -113,6 +114,7 @@ export class GetBucketEncryptionCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
];
})
.s("AmazonS3", "GetBucketEncryption", {})
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// smithy-typescript generated code
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
import { Command as $Command } from "@smithy/smithy-client";
Expand Down Expand Up @@ -133,6 +134,7 @@ export class GetBucketIntelligentTieringConfigurationCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
];
})
.s("AmazonS3", "GetBucketIntelligentTieringConfiguration", {})
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// smithy-typescript generated code
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
import { Command as $Command } from "@smithy/smithy-client";
Expand Down Expand Up @@ -141,6 +142,7 @@ export class GetBucketInventoryConfigurationCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
];
})
.s("AmazonS3", "GetBucketInventoryConfiguration", {})
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// smithy-typescript generated code
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
import { Command as $Command } from "@smithy/smithy-client";
Expand Down Expand Up @@ -216,6 +217,7 @@ export class GetBucketLifecycleConfigurationCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
];
})
.s("AmazonS3", "GetBucketLifecycleConfiguration", {})
Expand Down
2 changes: 2 additions & 0 deletions clients/client-s3/src/commands/GetBucketLocationCommand.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// smithy-typescript generated code
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
import { Command as $Command } from "@smithy/smithy-client";
Expand Down Expand Up @@ -119,6 +120,7 @@ export class GetBucketLocationCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
];
})
.s("AmazonS3", "GetBucketLocation", {})
Expand Down
2 changes: 2 additions & 0 deletions clients/client-s3/src/commands/GetBucketLoggingCommand.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// smithy-typescript generated code
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
import { Command as $Command } from "@smithy/smithy-client";
Expand Down Expand Up @@ -113,6 +114,7 @@ export class GetBucketLoggingCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
];
})
.s("AmazonS3", "GetBucketLogging", {})
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// smithy-typescript generated code
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
import { Command as $Command } from "@smithy/smithy-client";
Expand Down Expand Up @@ -136,6 +137,7 @@ export class GetBucketMetricsConfigurationCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
];
})
.s("AmazonS3", "GetBucketMetricsConfiguration", {})
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// smithy-typescript generated code
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
import { Command as $Command } from "@smithy/smithy-client";
Expand Down Expand Up @@ -160,6 +161,7 @@ export class GetBucketNotificationConfigurationCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
];
})
.s("AmazonS3", "GetBucketNotificationConfiguration", {})
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// smithy-typescript generated code
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
import { Command as $Command } from "@smithy/smithy-client";
Expand Down Expand Up @@ -102,6 +103,7 @@ export class GetBucketOwnershipControlsCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
];
})
.s("AmazonS3", "GetBucketOwnershipControls", {})
Expand Down
2 changes: 2 additions & 0 deletions clients/client-s3/src/commands/GetBucketPolicyCommand.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// smithy-typescript generated code
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
import { Command as $Command } from "@smithy/smithy-client";
Expand Down Expand Up @@ -152,6 +153,7 @@ export class GetBucketPolicyCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
];
})
.s("AmazonS3", "GetBucketPolicy", {})
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// smithy-typescript generated code
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
import { Command as $Command } from "@smithy/smithy-client";
Expand Down Expand Up @@ -108,6 +109,7 @@ export class GetBucketPolicyStatusCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
];
})
.s("AmazonS3", "GetBucketPolicyStatus", {})
Expand Down
2 changes: 2 additions & 0 deletions clients/client-s3/src/commands/GetBucketReplicationCommand.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// smithy-typescript generated code
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
import { Command as $Command } from "@smithy/smithy-client";
Expand Down Expand Up @@ -198,6 +199,7 @@ export class GetBucketReplicationCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
];
})
.s("AmazonS3", "GetBucketReplication", {})
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// smithy-typescript generated code
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
import { Command as $Command } from "@smithy/smithy-client";
Expand Down Expand Up @@ -104,6 +105,7 @@ export class GetBucketRequestPaymentCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
];
})
.s("AmazonS3", "GetBucketRequestPayment", {})
Expand Down
2 changes: 2 additions & 0 deletions clients/client-s3/src/commands/GetBucketTaggingCommand.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// smithy-typescript generated code
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
import { Command as $Command } from "@smithy/smithy-client";
Expand Down Expand Up @@ -137,6 +138,7 @@ export class GetBucketTaggingCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
];
})
.s("AmazonS3", "GetBucketTagging", {})
Expand Down
2 changes: 2 additions & 0 deletions clients/client-s3/src/commands/GetBucketVersioningCommand.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// smithy-typescript generated code
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
import { Command as $Command } from "@smithy/smithy-client";
Expand Down Expand Up @@ -118,6 +119,7 @@ export class GetBucketVersioningCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
];
})
.s("AmazonS3", "GetBucketVersioning", {})
Expand Down
2 changes: 2 additions & 0 deletions clients/client-s3/src/commands/GetBucketWebsiteCommand.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// smithy-typescript generated code
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
import { Command as $Command } from "@smithy/smithy-client";
Expand Down Expand Up @@ -142,6 +143,7 @@ export class GetBucketWebsiteCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
];
})
.s("AmazonS3", "GetBucketWebsite", {})
Expand Down
2 changes: 2 additions & 0 deletions clients/client-s3/src/commands/GetObjectAclCommand.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// smithy-typescript generated code
import { getThrow200ExceptionsPlugin } from "@aws-sdk/middleware-sdk-s3";
import { getEndpointPlugin } from "@smithy/middleware-endpoint";
import { getSerdePlugin } from "@smithy/middleware-serde";
import { Command as $Command } from "@smithy/smithy-client";
Expand Down Expand Up @@ -192,6 +193,7 @@ export class GetObjectAclCommand extends $Command
return [
getSerdePlugin(config, this.serialize, this.deserialize),
getEndpointPlugin(config, Command.getEndpointParameterInstructions()),
getThrow200ExceptionsPlugin(config),
];
})
.s("AmazonS3", "GetObjectAcl", {})
Expand Down
Loading

0 comments on commit 9119ae6

Please sign in to comment.