Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename calculateSha256 functions #790

Merged
merged 1 commit into from
Jan 27, 2020

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Jan 24, 2020

Renames calculateSha256 to fileStreamHasher and blobHasher. Each function takes a Hash constructor and thus can return other hashes beyond Sha256.

Updates S3 Client where these functions are currently used.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@srchase srchase requested a review from trivikr January 24, 2020 23:29
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-io
Copy link

Codecov Report

Merging #790 into smithy-codegen will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           smithy-codegen     #790   +/-   ##
===============================================
  Coverage           92.42%   92.42%           
===============================================
  Files                 142      142           
  Lines                2811     2811           
  Branches              487      487           
===============================================
  Hits                 2598     2598           
  Misses                213      213
Impacted Files Coverage Δ
packages/hash-stream-node/src/index.ts 90% <100%> (ø) ⬆️
packages/hash-blob-browser/src/index.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bf0168...bfa2a6d. Read the comment docs.

@srchase
Copy link
Contributor Author

srchase commented Jan 27, 2020

CI failure is due to flaky test, and is unrelated #487

@srchase srchase merged commit ba66532 into aws:smithy-codegen Jan 27, 2020
@srchase srchase deleted the rename-calculateSha256 branch January 27, 2020 18:26
@lock
Copy link

lock bot commented Feb 3, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants