Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-http2-handler.spec intermittently fails for abortSignal will close request on session when aborted #487

Closed
srchase opened this issue Dec 3, 2019 · 7 comments
Assignees
Labels

Comments

@srchase
Copy link
Contributor

srchase commented Dec 3, 2019

The abortSignal test intermittently fails CI:

PASS  packages/fetch-http-handler/build/fetch-http-handler.spec.js

 FAIL  packages/node-http-handler/build/node-http2-handler.spec.js

  ● NodeHttp2Handler › abortSignal › will close request on session when aborted

    expect(received).rejects.toHaveProperty()

    Received promise resolved instead of rejected

smithy-codegen as of b831fe8

Is the issue in the browser/Node.js?
NA: CI

@trivikr
Copy link
Member

trivikr commented Dec 6, 2019

This happened only in Travis

The commit to remove TravisCI was cherry-picked in smithy-codegen branch d37c4b3

This issue can be resolved if issue doesn't reproduce in smithy-codegen

@trivikr
Copy link
Member

trivikr commented Jan 23, 2020

Cloding as the issue hasn't reproduced in smithy-codegen

@trivikr trivikr closed this as completed Jan 23, 2020
@trivikr
Copy link
Member

trivikr commented Jan 23, 2020

Was closed by mistake

Reopening as the issue did reproduce in smithy-codegen in severals PRs.
Latest one #782 (comment)

@trivikr
Copy link
Member

trivikr commented Jan 24, 2020

Flaky test in #787 (comment)

@ajredniwja
Copy link
Contributor

@srchase is this still a persisting issue?

@AllanZhengYP AllanZhengYP added the CI/CD This is related to CI/CD label Mar 6, 2020
@trivikr trivikr changed the title Node Http2 Handler Spec fails intermittently node-http2-handler.spec intermittently fails for abortSignal will close request on session when aborted Jan 27, 2021
trivikr added a commit to trivikr/aws-sdk-js-v3 that referenced this issue Jul 8, 2021
@github-actions
Copy link

Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jan 28, 2022
@github-actions github-actions bot closed this as completed Feb 1, 2022
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants