Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for the aws.ec2 protocol #791

Merged
merged 2 commits into from
Jan 27, 2020
Merged

feat: Add support for the aws.ec2 protocol #791

merged 2 commits into from
Jan 27, 2020

Conversation

kstich
Copy link
Contributor

@kstich kstich commented Jan 24, 2020

This commit adds support for the aws.ec2 protocol, building on top
of the HttpRpcProtocolGenerator, Xml[Member|Shape]DeserVisitor,
and Query[Member|Shape]SerVisitor for document serde.

The QueryShapeSerVisitor has been opened up for re-use by the new
Ec2ShapeSerVisitor because aws.ec2 is a specific version of the
aws.query protocol. Hooks have been made available to influence
the specific behavior that is updated.

This also fixes a critical bug with query list and map serialization
that would have resulted in runtime failues on serilaizing the member
target shape's contents.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kstich kstich requested a review from mtdowling January 24, 2020 23:59
@kstich kstich changed the title Add support for the aws.ec2 protocol feat: Add support for the aws.ec2 protocol Jan 24, 2020
@codecov-io
Copy link

codecov-io commented Jan 25, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (smithy-codegen@106061b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             smithy-codegen     #791   +/-   ##
=================================================
  Coverage                  ?   92.21%           
=================================================
  Files                     ?      144           
  Lines                     ?     2851           
  Branches                  ?      489           
=================================================
  Hits                      ?     2629           
  Misses                    ?      222           
  Partials                  ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 106061b...e232e6d. Read the comment docs.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr
Copy link
Member

trivikr commented Jan 25, 2020

CI failure is due to flaky test, and is unrelated #487

mtdowling
mtdowling requested changes Jan 27, 2020
View reviewed changes
...s-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AwsEc2.java Outdated Show resolved Hide resolved
...s-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AwsEc2.java Outdated Show resolved Hide resolved
...-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/Ec2ShapeSerVisitor.java Outdated Show resolved Hide resolved
...-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/Ec2ShapeSerVisitor.java Show resolved Hide resolved
...odegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/QueryShapeSerVisitor.java Outdated Show resolved Hide resolved
...odegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/QueryShapeSerVisitor.java Show resolved Hide resolved
@trivikr
Copy link
Member

trivikr commented Jan 27, 2020

The flaky test in node-http2-handler was commented out in #794
You can rebase from upstream/smithy-codegen to get the latest changes

@kstich
Add support for the aws.ec2 protocol
270e7b3 
This commit adds support for the `aws.ec2` protocol, building on top
of the `HttpRpcProtocolGenerator`, `Xml[Member|Shape]DeserVisitor`,
and `Query[Member|Shape]SerVisitor` for document serde.

The `QueryShapeSerVisitor` has been opened up for re-use by the new
`Ec2ShapeSerVisitor` because `aws.ec2` is a specific version of the
`aws.query` protocol. Hooks have been made available to influence
the specific behavior that is updated.

This also fixes a critical bug with query list and map serialization
that would have resulted in runtime failues on serilaizing the member
target shape's contents.
@kstich
Update to empty default error code
e232e6d
@kstich kstich requested a review from mtdowling January 27, 2020 21:31
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kstich kstich merged commit 120c70d into aws:smithy-codegen Jan 27, 2020
This was referenced Jan 27, 2020
Merged
Merged
@lock
Copy link

lock bot commented Feb 3, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtdowling mtdowling mtdowling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kstich @codecov-io @aws-sdk-js-automation @trivikr @mtdowling