Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multi-byte body lengths for browser #1101

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Conversation

tkashi
Copy link
Contributor

@tkashi tkashi commented Apr 20, 2020

Issue #, if available:
#1100

Description of changes:
Change implementation of calculateBodyLength for a browser so that multi byte body can be handled.
Add a test for this change as well as ones for this function (since there was no test).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

Codecov Report

Merging #1101 into master will decrease coverage by 5.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1101      +/-   ##
==========================================
- Coverage   78.79%   73.54%   -5.26%     
==========================================
  Files         279      284       +5     
  Lines       11599    13021    +1422     
  Branches     2402     3033     +631     
==========================================
+ Hits         9140     9576     +436     
- Misses       2459     3445     +986     
Impacted Files Coverage Δ
packages/util-body-length-browser/src/index.ts 71.42% <ø> (ø)
protocol_tests/aws-ec2/EC2ProtocolClient.ts 96.00% <ø> (ø)
...ws-ec2/commands/EmptyInputAndEmptyOutputCommand.ts 100.00% <ø> (ø)
...ests/aws-ec2/commands/GreetingWithErrorsCommand.ts 100.00% <ø> (ø)
.../aws-ec2/commands/IgnoresWrappingXmlNameCommand.ts 100.00% <ø> (ø)
..._tests/aws-ec2/commands/NestedStructuresCommand.ts 88.23% <ø> (ø)
..._tests/aws-ec2/commands/NoInputAndOutputCommand.ts 100.00% <ø> (ø)
...2/commands/QueryIdempotencyTokenAutoFillCommand.ts 88.23% <ø> (ø)
...otocol_tests/aws-ec2/commands/QueryListsCommand.ts 88.23% <ø> (ø)
...l_tests/aws-ec2/commands/QueryTimestampsCommand.ts 88.23% <ø> (ø)
... and 172 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dfb40f...7ef26cd. Read the comment docs.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 7ef26cd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@AllanZhengYP
Copy link
Contributor

@tkashi Thank you a lot for the PR! It makes sense to me. I will approve it after confirming it works in ReactNative

@AllanZhengYP AllanZhengYP merged commit 65a3658 into aws:master Apr 28, 2020
@lock
Copy link

lock bot commented May 5, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants