fix: move endpoint resolution to the serializers #1106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a regression introduced in #1097
Paired with smithy-lang/smithy-typescript#162
Previously,
client.config.endpoint
, which is aProvider<Endpoint>
is resolved in serializer middleware:aws-sdk-js-v3/packages/middleware-serde/src/serializerMiddleware.ts
Lines 23 to 26 in fde80bf
SerDeContext.endpoint
and actually anEndpoint
but typed inProvider<Endpoint>
.This change move the endpoint resolution to the serializer itself
SerDeContext.endpoint
is a provider function accross the board.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.