Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move endpoint resolution to the serializers #1106

Merged
merged 3 commits into from
Apr 24, 2020

Conversation

AllanZhengYP
Copy link
Contributor

Fix a regression introduced in #1097
Paired with smithy-lang/smithy-typescript#162

Previously, client.config.endpoint, which is a Provider<Endpoint> is resolved in serializer middleware:

const endpointResolvedOptions = {
...options,
endpoint: await options.endpoint()
};
. But the type is not changed. As a result, the SerDeContext.endpoint and actually an Endpoint but typed in Provider<Endpoint>.

This change move the endpoint resolution to the serializer itself SerDeContext.endpoint is a provider function accross the board.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation

This comment has been minimized.

@codecov-io
Copy link

codecov-io commented Apr 24, 2020

Codecov Report

Merging #1106 into master will decrease coverage by 5.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1106      +/-   ##
==========================================
- Coverage   78.79%   73.54%   -5.26%     
==========================================
  Files         279      283       +4     
  Lines       11599    13014    +1415     
  Branches     2402     3030     +628     
==========================================
+ Hits         9140     9571     +431     
- Misses       2459     3443     +984     
Impacted Files Coverage Δ
packages/middleware-stack/src/MiddlewareStack.ts 88.61% <ø> (ø)
protocol_tests/aws-ec2/EC2ProtocolClient.ts 96.00% <ø> (ø)
...ws-ec2/commands/EmptyInputAndEmptyOutputCommand.ts 100.00% <ø> (ø)
...ests/aws-ec2/commands/GreetingWithErrorsCommand.ts 100.00% <ø> (ø)
.../aws-ec2/commands/IgnoresWrappingXmlNameCommand.ts 100.00% <ø> (ø)
..._tests/aws-ec2/commands/NestedStructuresCommand.ts 88.23% <ø> (ø)
..._tests/aws-ec2/commands/NoInputAndOutputCommand.ts 100.00% <ø> (ø)
...2/commands/QueryIdempotencyTokenAutoFillCommand.ts 88.23% <ø> (ø)
...otocol_tests/aws-ec2/commands/QueryListsCommand.ts 88.23% <ø> (ø)
...l_tests/aws-ec2/commands/QueryTimestampsCommand.ts 88.23% <ø> (ø)
... and 170 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fde80bf...1e7922c. Read the comment docs.

@AllanZhengYP AllanZhengYP force-pushed the fix-context-endpoint branch from 3beee4a to 05b7aec Compare April 24, 2020 22:13
@aws-sdk-js-automation

This comment has been minimized.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 1e7922c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@AllanZhengYP AllanZhengYP merged commit 08c9420 into aws:master Apr 24, 2020
@lock
Copy link

lock bot commented May 5, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants