Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert CI on CodeBuild using GitHub Actions #1278

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jun 16, 2020

This reverts commit 57a35a7.

Issue #, if available:
Fixes: #1267

Description of changes:

Revert CI on CodeBuild using GitHub Actions.

Reasons for revert:

  • The Action used GitHub secrets to store AWS credentials.
  • GitHub Secrets are not shared with forks, and there's no plan to do so because of security reasons (details)
  • When a PR is cut from fork, the secrets of the fork are used.

We'll re-introduce GitHub Actions without CodeBuild like attempted in #1272 after moving to root TSConfig with compilerOptions.paths and ts-jest.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@trivikr trivikr merged commit ddfaabc into aws:master Jun 16, 2020
@trivikr trivikr deleted the remove-github-action branch June 16, 2020 17:32
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Action fails to configure AWS credentials when PR is cut from fork
2 participants