Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(client-sts): defaultRoleAssumers should not be edited directly #2360

Merged
merged 3 commits into from
May 10, 2021

Conversation

AllanZhengYP
Copy link
Contributor

Description

Unblock #2359. It was caused by #2353 got overwritten, because the template was not updated.
Added a description that contributors shouldn't touch this file.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@4904f6a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2360   +/-   ##
=======================================
  Coverage        ?   58.88%           
=======================================
  Files           ?      482           
  Lines           ?    25928           
  Branches        ?     6154           
=======================================
  Hits            ?    15267           
  Misses          ?    10661           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4904f6a...05d3c83. Read the comment docs.

@trivikr trivikr changed the title fix(client-sts): add docs that defaultRoleAssumers should not be edited directly docs(client-sts): defaultRoleAssumers should not be edited directly May 10, 2021
@trivikr trivikr merged commit 596fed0 into aws:main May 10, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants