chore(codegen): pin smithy to 1.8.x

[trivikr]

Issue

Follow-up to #2153

Description

Pins smithy to minor version 1.8.x

Testing

CI

---

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (main@6ef34b5). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2499   +/-   ##
=======================================
  Coverage        ?   59.54%           
=======================================
  Files           ?      494           
  Lines           ?    26394           
  Branches        ?     6269           
=======================================
  Hits            ?    15715           
  Misses          ?    10679           
  Partials        ?        0           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ef34b5...58c2e13. Read the comment docs.

[trivikr]

Error thrown:

      578 |     if (err.name !== "CustomCodeError") {
      579 |       console.log(err);
    > 580 |       fail(`Expected a CustomCodeError to be thrown, got ${err.name} instead`);
          |       ^
      581 |       return;
      582 |     }
      583 |     const r: any = err;

It requires supporting aws.protocols#awsQueryError trait for releasing clients on 06/17 with #2498

Relevant PRs in Go SDK:

• smithy-go Support the delegation of determining the errors that can occur for an operation smithy-go#304
• aws-sdk-go-v2 awsQueryError trait support aws-sdk-go-v2#1283

The test in manually skipped for this PR in eee4e7b (#2499), and will be followed up in a different PR.

[trivikr]

New error:

RestJsonHttpRequestLabelEscaping:Request
    expect(received).toBe(expected) // Object.is equality
    Expected: "/HttpRequestWithLabels/%25%3A%2F%3F%23%5B%5D%40%21%24%26%27%28%29%2A%2B%2C%3B%3D%F0%9F%98%B9/1/2/3/4.1/5.1/true/2019-12-16T23%3A48%3A18Z"
    Received: "/HttpRequestWithLabels/%25%3A%2F%3F%23%5B%5D%40%21%24%26%27%28%29%2a%2B%2C%3B%3D%F0%9F%98%B9/1/2/3/4.1/5.1/true/2019-12-16T23%3A48%3A18Z"
      1783 |     const r = err.request;
      1784 |     expect(r.method).toBe("GET");
    > 1785 |     expect(r.path).toBe(
           |                    ^
      1786 |       "/HttpRequestWithLabels/%25%3A%2F%3F%23%5B%5D%40%21%24%26%27%28%29%2A%2B%2C%3B%3D%F0%9F%98%B9/1/2/3/4.1/5.1/true/2019-12-16T23%3A48%3A18Z"
      1787 |     );
      1788 |
      at Object.<anonymous> (tests/functional/restjson1.spec.ts:1785:20)

Error: The character "*" is encoded as "%2a"
As per rfc3986 section 2.1, it should be "%2A"

The uppercase hexadecimal digits 'A' through 'F' are equivalent to
the lowercase digits 'a' through 'f', respectively. If two URIs
differ only in the case of hexadecimal digits used in percent-encoded
octets, they are equivalent. For consistency, URI producers and
normalizers should use uppercase hexadecimal digits for all percent-
encodings.

[alexforsyth]

+1

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.