fix: Check error body before dereference when producing error codes #3085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not a perfect solution, and I certainly have no business editing this code. But I do want to get AWS's attention to get this fixed.
fluggo
changed the title
Codecov Report
@@ Coverage Diff @@
## main #3085 +/- ##
=======================================
Coverage 58.72% 58.72%
=======================================
Files 571 571
Lines 30622 30622
Branches 7541 7541
=======================================
Hits 17984 17984
Misses 12638 12638 Continue to review full report at Codecov.
|
|
This has been added in #4367 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a perfect solution, and I certainly have no business editing this code.
But I do want to get AWS's attention to get this fixed.
Issue
Issue number #2861
Description
This fixes the TypeError that occurs when AWS sends back a blank response to a query.
Testing
I didn't test it, but the original issue's been open for two months without a fix, and I figure it's bad for AWS to push us to use its shiny new V3 API when it's a little broken.
Additional context
Add any other context about the PR here.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.