chore(tsconfig): use recommendations from @tsconfig/node12 for cjs #3182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanZhengYP
approved these changes
Jan 13, 2022
| "noEmitHelpers": true, | ||
| "target": "ES2018", | ||
| "target": "es2019", | ||
|
|
There was a problem hiding this comment.
I wanted to demarcate main key: i.e. lib, module, target from the rest.
We should bump to yarn berry, and put constraints for such and other rules.
Anyway, we can't merge this change as CI is failing, as we define tsconfig.cjs.json for a browser package.
We should write a yarn berry constraints for browser, node, and universal packages and a standardized way for defining runtime specific packages.
This was referenced Jan 24, 2022
|
Closing as this PR was abandoned due to multiple CI failures. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Follow-up to #3141
The Node.js 10.x was deprecated, but TSConfig still had ES2018 as a target
Description
Updates target in
tsconfig.cjs.jsonas recommendation from@tsconfig/node12Refs: https://github.com/tsconfig/bases/blob/main/bases/node12.json
Testing
CI
Additional Context
We can't extend
@tsconfig/node12as Typescript extends doesn't support array.Refs: microsoft/TypeScript#29118
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.