Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert support for awsQueryError trait #3193

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 14, 2022

Issue

Internal JS-3027

This code change surfaced a bug in our error deserializer, where the error message is modeled to be in key message but the actual message is response payload with key Message.

Description

This reverts commit 351bd3a added in #3174.

Testing

Integration tests were successful.

$ yarn test:integration:legacy
yarn run v1.22.17
$ cucumber-js --fail-fast
.......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

150 scenarios (150 passed)
523 steps (523 passed)
1m43.243s
Done in 104.70s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review January 14, 2022 22:08
@trivikr trivikr requested a review from a team as a code owner January 14, 2022 22:08
@AllanZhengYP AllanZhengYP merged commit d3000f8 into aws:main Jan 14, 2022
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2022
@trivikr trivikr deleted the revert-aws-query-error-trait branch August 26, 2022 02:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants