Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package.json): delete *.tsbuildinfo in clean script #3334

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Feb 18, 2022

Issue

Fixes: #3209
Fixes: #3297

Description

Deletes *.tsbuildinfo in clean script
Also ensures that v3.52.0 will release all packages, fixing missing downlevel types.

Testing

Verified that *.tsbuildinfo files are deleted on running yarn clean

console.log output
$ > cd clients/client-acm
 
$ client-acm> yarn build
...

$ client-acm> ls
CHANGELOG.md  LICENSE       src                       tsconfig.es.tsbuildinfo     typedoc.json
dist-cjs      node_modules  tsconfig.cjs.json         tsconfig.json
dist-es       package.json  tsconfig.cjs.tsbuildinfo  tsconfig.types.json
dist-types    README.md     tsconfig.es.json          tsconfig.types.tsbuildinfo

$ client-acm> yarn clean
yarn run v1.22.17
$ rimraf ./dist-* && rimraf *.tsbuildinfo
Done in 0.15s.

$ client-acm> ls
CHANGELOG.md  node_modules  README.md  tsconfig.cjs.json  tsconfig.json        typedoc.json
LICENSE       package.json  src        tsconfig.es.json   tsconfig.types.json

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr merged commit a6d95f3 into aws:main Feb 18, 2022
@trivikr trivikr deleted the rimraf-tsbuildinfo branch February 18, 2022 19:26
@github-actions
Copy link

github-actions bot commented Mar 5, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing down-leveled declarations (dist-types/ts3.4) The clean commands should also delete *.tsbuildinfo
2 participants