Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(endpoint): test fixes for s3-control related to endpoints 2.0 #4065

Merged
merged 2 commits into from
Oct 20, 2022

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Oct 20, 2022

split out from #4064

Issue

internal P73764220

Description

  • fix unit tests in s3-control client

Testing

Verify unit tests are successful

$ client-s3-control> yarn build:include:deps

$ client-s3-control> yarn ts-mocha test/S3Control.spec.ts

  S3Control Client
    CreateBucket
      ✔ should populate correct endpoint and signing region
      ✔ should populate correct endpoint and signing region if OutpostId is supplied
    ListRegionalBuckets
      ✔ should populate correct endpoint and signing region
      ✔ should populate correct endpoint and signing region if OutpostId is supplied
    Outposts Access Point ARN
      ✔ should populate correct endpoint if Access Point name is non-ARN
      ✔ should populate correct endpoint and signing region if Access Point name is ARN
    Outposts Bucket ARN
      ✔ should populate correct endpoint if Bucket name is non-ARN
      ✔ should populate correct endpoint and signing region if Bucket name is ARN


  8 passing (115ms)

Done in 1.63s.

@kuhe kuhe requested a review from a team as a code owner October 20, 2022 17:57
@trivikr trivikr self-requested a review October 20, 2022 18:05
@trivikr trivikr merged commit 25af672 into aws:main Oct 20, 2022
@kuhe kuhe deleted the fix/s3-control-unit-tests-endpoints branch October 20, 2022 18:19
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants