fix(smithy-client): optional param in error handling path #4410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krosenk729 looking at #4367, I think what's actually required to fix is the Java code for the codegen (example). |
|
(we also noticed this new issue, following the fix for #2861) |
kuhe
approved these changes
Feb 23, 2023
siddsriv
approved these changes
Feb 23, 2023
|
this file is not generated, so this fix can be merged as-is |
milesziemer
approved these changes
Feb 23, 2023
trivikr
changed the title
|
Hi there, is this fix released? I am using "@aws-sdk/client-sqs": "^3.43.0", To integrate a fix for this and #2861, which version shall I integrate? |
|
Thanks @Drarig29 ! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Additional fix for #2861
Description
After the fix for #2861 was merged, we are getting
TypeError: Cannot read properties of undefined (reading 'code') at throwDefaultError (/usr/src/service/node_modules/@aws-sdk/client-sqs/node_modules/@aws-sdk/smithy-client/dist-cjs/default-error-handler.js:9:26)becauseparsedBodycan be undefined nowTesting
codegen and CI
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.