Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): bump ts-loader version #4546

Merged
merged 1 commit into from
Mar 19, 2023
Merged

fix(e2e): bump ts-loader version #4546

merged 1 commit into from
Mar 19, 2023

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Mar 19, 2023

Issue

n/a

Description

Bump ts-loader version to bring in a fix related to the TypeScript version.

Testing

node tests/e2e/index.js fails without this change.

Is any other testing needed? ts-loader and ts-node appear to be mainly for Karma and e2e.

new output of npm ls ts-node

├─┬ @commitlint/cli@17.0.2
│ └─┬ @commitlint/load@17.4.2
│   ├─┬ cosmiconfig-typescript-loader@4.3.0
│   │ └── ts-node@10.9.1 deduped
│   └── ts-node@10.9.1 deduped
├─┬ jest@28.1.1
│ ├─┬ @jest/core@28.1.3
│ │ └─┬ jest-config@28.1.3
│ │   └── ts-node@10.9.1 deduped
│ └─┬ jest-cli@28.1.3
│   └─┬ jest-config@28.1.3
│     └── ts-node@10.9.1 deduped
├─┬ ts-mocha@10.0.0
│ └── ts-node@7.0.1
└── ts-node@10.9.1

@kuhe kuhe marked this pull request as ready for review March 19, 2023 20:27
@kuhe kuhe requested a review from a team as a code owner March 19, 2023 20:27
@trivikr trivikr merged commit 96ca38c into aws:main Mar 19, 2023
@kuhe kuhe deleted the fix/ts-loader branch March 20, 2023 15:21
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants