Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(middleware-sdk-s3-control): ignore IP address in host prefix dedupe #4944

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Jul 10, 2023

Issue

n/a

Description

Do not deduplicate the two leading hostname components if they are part of an IP address.

Testing

new unit test

@kuhe kuhe requested review from a team as code owners July 10, 2023 16:10
@kuhe kuhe merged commit 6dd73dd into aws:main Jul 10, 2023
@kuhe kuhe deleted the fix/s3-control branch July 10, 2023 17:09
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants