Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): treat private test packages as non-clients #5138

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Aug 23, 2023

Issue

fixes: #5136

Description

Make private test packages as non-clients in runtime-dep-version-check script.

Testing

Verified that no error are thrown by runtime-dep-version-check script in #5137


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner August 23, 2023 22:16
@trivikr trivikr changed the title fix(scripts): make private test packages as non-clients fix(scripts): treat private test packages as non-clients Aug 23, 2023
@trivikr trivikr merged commit 87d43ab into aws:main Aug 23, 2023
2 checks passed
@trivikr trivikr deleted the fix-runtim-dep-version-check branch August 23, 2023 23:36
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The runtime-dep-version-check is failing when bumping smithy deps
2 participants