Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove deprecated ts-jest globals config #6050

Merged
merged 4 commits into from
May 7, 2024

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented May 2, 2024

Issue

Noticed while working on #6038

Description

Removes deprecated ts-jest globals config

Testing

Before

ts-jest emits warning

$ aws-restjson-server> yarn test
...
ts-jest[ts-jest-transformer] (WARN) Define `ts-jest` config under `globals` is deprecated. Please do
transform: {
    <transform_regex>: ['ts-jest', { /* ts-jest config goes here in Jest */ }],
},
..
Ran all test suites.
Done in 13.89s.

After

ts-jest does not emit warning

$ aws-restjson-server> yarn test
...
Ran all test suites.
Done in 14.20s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review May 7, 2024 22:18
@trivikr trivikr requested a review from a team as a code owner May 7, 2024 22:18
@trivikr trivikr merged commit 67fbd23 into aws:main May 7, 2024
5 checks passed
@trivikr trivikr deleted the remove-ts-jest-globals branch May 7, 2024 23:49
siddsriv pushed a commit to siddsriv/aws-sdk-js-v3 that referenced this pull request May 8, 2024
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants