-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(middleware-user-agent): add client config for userAgentAppId #6524
Conversation
4039d01
to
86b6c2d
Compare
b92582e
to
d731ec6
Compare
…options in utils for UA-node
...egen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddUserAgentDependency.java
Outdated
Show resolved
Hide resolved
@@ -41,5 +41,6 @@ export const getRuntimeConfig = (config: EchoServiceClientConfig) => { | |||
}), | |||
sha256: config?.sha256 ?? Hash.bind(null, "sha256"), | |||
streamCollector: config?.streamCollector ?? streamCollector, | |||
userAgentAppId: config?.userAgentAppId ?? loadNodeConfig(NODE_APP_ID_CONFIG_OPTIONS), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since defaultUserAgent is deprecated, the call on line 33 should be changed to createDefaultUserAgentProvider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do that codegen change to clients in a separate PR
Issue
Internal JS-5173
Description
Adds a client config field for
userAgentAppId
Testing
Unit tests:
util-user-agent-node
util-user-agent-browser
middleware-user-agent
runtimeConfig.ts
:By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.