Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues when SDK populates wrong path if access point arn contains forward slash #2989

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

AllanZhengYP
Copy link
Contributor

/cc @trivikr

Checklist
  • npm run test passes
  • changelog is added, npm run add-change

@codecov-io
Copy link

codecov-io commented Dec 4, 2019

Codecov Report

Merging #2989 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2989   +/-   ##
=======================================
  Coverage   97.05%   97.05%           
=======================================
  Files         325      325           
  Lines        9462     9462           
  Branches     1742     1742           
=======================================
  Hits         9183     9183           
  Misses        279      279
Impacted Files Coverage Δ
lib/services/s3.js 98.37% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b030cf8...39bf28c. Read the comment docs.

@AllanZhengYP AllanZhengYP requested a review from trivikr December 4, 2019 01:56
@AllanZhengYP AllanZhengYP merged commit ed9a30e into aws:master Dec 4, 2019
AllanZhengYP added a commit to AllanZhengYP/aws-sdk-js that referenced this pull request Dec 4, 2019
AllanZhengYP added a commit that referenced this pull request Dec 4, 2019
@lock
Copy link

lock bot commented Dec 11, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants