Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add yard app.js with patch to support jQuery v3.6.0 #3886

Merged
merged 3 commits into from
Sep 14, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Sep 13, 2021

Follow-up to #3876

Description

In #3876, we copied entire yard repo locally to bump jQuery version. This is not required, as we can just copy app.js file from upstream.

Also, the PR in upstream was not merged lsegal/yard#1399

Testing

The API reference preview can be viewed at https://aws-sdk-js-3886.netlify.app/

Checklist
  • run bundle exec rake docs:api and inspect doc/latest/index.html if documentation is changed
  • non-code related change (markdown/git settings etc)

@trivikr trivikr changed the title chore: apply patch to use latest jQuery to app.js from yard chore: add yard app.js with patch to support jQuery v3.6.0 Sep 13, 2021
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛳

@trivikr trivikr merged commit dca3449 into aws:master Sep 14, 2021
@trivikr trivikr deleted the use-yard-appjs branch September 14, 2021 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants