Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(event_listeners): do not add content length 0 to bodyless request methods #4199

Closed
wants to merge 1 commit into from
Closed

fix(event_listeners): do not add content length 0 to bodyless request methods #4199

wants to merge 1 commit into from

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Sep 5, 2022 •
edited
Loading

Do not add content length 0 header to GET, DELETE, TRACE, OPTIONS, and HEAD requests.

  • add/fix unit tests
Checklist
  • npm run test passes
  • n/a .d.ts file is updated
  • changelog is added, npm run add-change
  • run bundle exec rake docs:api and inspect doc/latest/index.html if documentation is changed
  • n/a run npm run integration if integration test is changed
  • n/a non-code related change (markdown/git settings etc)

@kuhe kuhe requested a review from a team as a code owner September 5, 2022 20:02
@kuhe kuhe force-pushed the fix/get-content-length-0 branch 3 times, most recently from 78bfb38 to 67e0262 Compare September 7, 2022 17:50
@kuhe kuhe force-pushed the fix/get-content-length-0 branch from 67e0262 to 42ef367 Compare September 7, 2022 17:53
@trivikr
Copy link
Member

trivikr commented Sep 27, 2022

Superceded by #4219

@trivikr trivikr closed this Sep 27, 2022
@kuhe kuhe deleted the fix/get-content-length-0 branch September 27, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuhe @trivikr