Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: trickle down s3_output in athena.to_iceberg #2767

Merged
merged 2 commits into from
Apr 9, 2024
Merged

fix: trickle down s3_output in athena.to_iceberg #2767

merged 2 commits into from
Apr 9, 2024

Conversation

jaidisido
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Detail

  • trickle down s3_output in athena.to_iceberg

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jaidisido jaidisido self-assigned this Apr 9, 2024
@jaidisido jaidisido linked an issue Apr 9, 2024 that may be closed by this pull request
wr.athena.to_iceberg touches file in awswrangler default athena bucket even if s3_output is specified #2766
Closed
@jaidisido jaidisido mentioned this pull request Apr 9, 2024
Closed
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 14f0377
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
  • Commit ID: 14f0377
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 3bec6cc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
  • Commit ID: 3bec6cc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido jaidisido merged commit de48a86 into main Apr 9, 2024
19 checks passed
@jaidisido jaidisido deleted the fix/missing-s3-output branch April 9, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kukushking kukushking kukushking approved these changes

@LeonLuttenberger LeonLuttenberger LeonLuttenberger approved these changes

@malachi-constant malachi-constant Awaiting requested review from malachi-constant

Assignees

@jaidisido jaidisido

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wr.athena.to_iceberg touches file in awswrangler default athena bucket even if s3_output is specified
4 participants
@jaidisido @malachi-constant @kukushking @LeonLuttenberger