feat: modify_refresh_interval flag in opensearch index_documents #2980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AvihaiSam
changed the title
AvihaiSam
changed the title
|
related to #2981 |
AvihaiSam
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
jaidisido
changed the title
jaidisido
reviewed
Oct 2, 2024
awswrangler/opensearch/_write.py
Outdated
| @@ -504,6 +504,7 @@ def index_documents( | |||
| initial_backoff: int | None = None, | |||
| max_backoff: int | None = None, | |||
| use_threads: bool | int = False, | |||
| modify_refresh_interval: bool = True, | |||
There was a problem hiding this comment.
Looks good, but perhaps enable_refresh_interval is a better name?
There was a problem hiding this comment.
sure... whatever works for you...
pushed the changes...
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
jaidisido
approved these changes
Oct 7, 2024
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Detail
add
modify_refresh_intervalargument to opensearch'sindex_documents()when set to
Falseit won't try to modify refresh interval.This argument is needed to be set to
Falseif multiple workers write to the same index, which might disable refresh-interval due to race condition.it's also possible that the backend role is not allowed to modify index settings (
indices:admin/settings/update)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.