Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing release 2.9.0 #751

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Preparing release 2.9.0 #751

merged 1 commit into from
Jun 17, 2021

Conversation

kukushking
Copy link
Contributor

Issue #, if available: N/A

Description of changes:

  • Bumping version
  • Python 3.6 compatibility fixes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

3.6 compatibility fixes
@jaidisido
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
  • Commit ID: f40479f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking kukushking merged commit 89b459d into main Jun 17, 2021
Copy link
Contributor

@jaidisido jaidisido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -19,7 +19,7 @@ RUN pip3 install -r /root/requirements.txt

ADD requirements-dev.txt /root/
# Removing "-e ." installation
RUN head -n -2 /root/requirements-dev.txt > /root/temp.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably come up with a better way of doing this. Perhaps filtering out any line that starts with -e instead?

@jaidisido jaidisido deleted the cb-tests branch June 17, 2021 20:45
@kukushking kukushking self-assigned this Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants