Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation for symfony/config 4.2+ #54

Merged
merged 1 commit into from
Feb 27, 2019

Conversation

bits4breakfast
Copy link
Contributor

Heavily inspired by symfony/maker-bundle#324

@bits4breakfast
Copy link
Contributor Author

It is currently failing tests with two very old PHP versions

@bits4breakfast
Copy link
Contributor Author

hi @howardlopez - what's the process for submitting a new PR? Thanks!

@howardlopez
Copy link
Contributor

@bits4breakfast - You can update this PR by simply committing to the branch to be merged. It will trigger a new round of Travis tests.

@bits4breakfast
Copy link
Contributor Author

@howardlopez - thanks. But are tests going to fail again for those PHP 5.3? Are they still supported?

@alegout
Copy link

alegout commented Jan 25, 2019

Hello,

any news?

@howardlopez
Copy link
Contributor

The Travis builds are currently failing for the PHP 5.5 and 5.6 builds, which are still supported. Since it's a memory limit issue, we'll have to look into the configuration to make sure it's set up in such a way that it can actually pass.

@howardlopez
Copy link
Contributor

howardlopez commented Feb 27, 2019

Closing and re-opening PR to trigger fresh Travis CI build with new Travis file that was recently merged in.

@howardlopez howardlopez reopened this Feb 27, 2019
@alegout
Copy link

alegout commented Feb 27, 2019

thank you @bits4breakfast && @howardlopez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants