Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove laminas/laminas-dependency-plugin requirement #73

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

samsonasik
Copy link
Contributor

laminas/laminas-dependency-plugin should only used in project.

@vincequeiroz
Copy link
Contributor

vincequeiroz commented Feb 8, 2021

Could it be possible remove this dependency?

@snapshotpl
Copy link
Contributor

@vincequeiroz yes, its required as migration tool

@Saeven
Copy link

Saeven commented Nov 9, 2021

Thanks for this PR @samsonasik

Yes, please remove this or at least upgrade it to ^2.2.0. Causing a number of issues.

@jarrettj
Copy link

+1

@vincequeiroz
Copy link
Contributor

Could you help us, @howardlopez?

@davidwindell
Copy link

Please can someone merge this?

@Saeven
Copy link

Saeven commented Apr 14, 2022

@davidwindell not sure if this helps you, but I needed this for a Laminas project - forked and submitted to packagist: https://packagist.org/packages/saeven/laminas-aws-sdk

@jarrettj
Copy link

Been over a year 🤷🏾‍♂️

@davidwindell
Copy link

Thanks @Saeven, appreciate that, will switch to your fork. I guess AWS have abandoned this repo now.

@stobrien89
Copy link
Member

Hi all,

Apologies for the delay. I agree that this should probably be used at the project level. I'll merge and cut another release.

@stobrien89 stobrien89 merged commit 94ac0ed into aws:master Apr 29, 2022
@samsonasik samsonasik deleted the patch-1 branch April 29, 2022 21:20
@jarrettj
Copy link

Yay! Thanks @stobrien89. Much appreciated. Maybe we as a community can also help if needed. Especially since we have apps depending on this module :)

@davidwindell
Copy link

@stobrien89 thanks however we can't use the module without the fork from @Saeven until PHP 8 support is added, is there any plans for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants