-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of RDS instance available/deleted waiters #84
Conversation
Did you get everything working? |
Hi Jeremy, Yes thanks, your comments were spot on. Got the tests working by configuring the services.json file and then tested Thanks for the help, hope this helps others get more similar commits in.
|
Awesome. I appreciate your work here very much. We'll get it merged in soon after the internal review is complete. |
I have been asked to see if you are willing to sign a CLA (see our CONTRIBUTING.md for more info). Please send me an email using the address on my GitHub profile and I'll send you the CLA. Thanks. |
@tomsmaddox Can I get your email address? Please send an email to the email address on my GitHub profile. Thanks. |
CLA received and approved. Will merge this in soon. Thanks. |
Merged. Awesome. That PR was perfect. Thanks again. |
Could this be extending to work on DBSnapshots? When I copy a db snapshot (for example) being able to wait until it is available would be useful. |
I'm happy to generate a PR, but I think my knowledge of the internals of AWS RDS services mean that I don't know all the available states or transitions to make me an ideal candidate for that. Though willing to learn. |
Alternatively, is there a way to build a generic waiter? |
@rquadling Would you mind opening up a separate issue for this request? |
See https://forums.aws.amazon.com/thread.jspa?messageID=450707