Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of RDS instance available/deleted waiters #84

Merged
merged 3 commits into from
Jun 6, 2013

Conversation

tomsmaddox
Copy link

@jeremeamia
Copy link
Contributor

Did you get everything working?

@tomsmaddox
Copy link
Author

Hi Jeremy,

Yes thanks, your comments were spot on.

Got the tests working by configuring the services.json file and then tested
the waiters in my backup scripts and they're a-ok.

Thanks for the help, hope this helps others get more similar commits in.
On 13 May 2013 19:35, "Jeremy Lindblom" notifications@github.com wrote:

Did you get everything working?


Reply to this email directly or view it on GitHubhttps://github.com//pull/84#issuecomment-17831348
.

@jeremeamia
Copy link
Contributor

Awesome. I appreciate your work here very much. We'll get it merged in soon after the internal review is complete.

@jeremeamia
Copy link
Contributor

I have been asked to see if you are willing to sign a CLA (see our CONTRIBUTING.md for more info). Please send me an email using the address on my GitHub profile and I'll send you the CLA. Thanks.

@jeremeamia
Copy link
Contributor

@tomsmaddox Can I get your email address? Please send an email to the email address on my GitHub profile. Thanks.

@jeremeamia
Copy link
Contributor

CLA received and approved. Will merge this in soon. Thanks.

@jeremeamia jeremeamia merged commit ebe3a77 into aws:master Jun 6, 2013
@jeremeamia
Copy link
Contributor

Merged. Awesome. That PR was perfect. Thanks again.

@rquadling
Copy link
Contributor

Could this be extending to work on DBSnapshots?

When I copy a db snapshot (for example) being able to wait until it is available would be useful.

@rquadling
Copy link
Contributor

I'm happy to generate a PR, but I think my knowledge of the internals of AWS RDS services mean that I don't know all the available states or transitions to make me an ideal candidate for that. Though willing to learn.

@rquadling
Copy link
Contributor

Alternatively, is there a way to build a generic waiter?

@kstich
Copy link
Contributor

kstich commented Sep 8, 2017

@rquadling Would you mind opening up a separate issue for this request?

@rquadling rquadling mentioned this pull request Sep 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants