Fix Presigner not respecting :endpoint URL scheme #1027
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a failing test here, essentially because the client call within expects the |
When presigned URL is generated for a client which has `:endpoint`, the URL scheme was always "https", even when the `:endpoint` had "http" scheme.
janko
force-pushed
the
presigner-endpoint-scheme
branch
from
72262ce to
f0d2cf8
Compare
|
Updated. |
|
I've pulled down and confirmed that this doesn't break our integration tests around presigning. |
|
I like the idea, but I think this can be changed to be more generally applicable. I'm going to pull this down, modify it, and push. |
|
I pulled this locally and made a small change to ensure this worked for all URIs by default. Your changes have been merged into mainline. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When presigned URL is generated for a client which has
:endpoint, the URL scheme was always "https", even when the:endpointhad "http" scheme.