-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle expected boolean values for waiter error matcher #3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I plan do some rubocop adjustments once the PR has been approved. Keeping as it is to help out with readability. |
mullermp
reviewed
Jul 25, 2024
Moving to Draft mode since I need to do some audits and add/update existing waiter specs |
Self-reminder: Revert 1a61acd after approvals |
mullermp
approved these changes
Aug 8, 2024
alextwoods
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice - great additional tests.
This reverts commit 1a61acd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All services currently define waiter error acceptors that have expected string values that represent an AWS Error code like below:
A waiter with this acceptor will continue to wait until an error the the code
ResourceNotFoundFault
is received or the max amount of attempts is reached.However, it's possible for service teams to define a waiter error acceptor like below which has an expected boolean (true or false) value. The expected behavior is defined below:
true - Match an error code with any value.
false - Match if no errors were encountered
Example:
A waiter with this acceptor will continue to wait until a response with no error is received or the max amount of attempts is reached.
This PR adds the ability for waiters to handle the acceptors described above.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
To make sure we include your contribution in the release notes, please make sure to add description entry for your changes in the "unreleased changes" section of the
CHANGELOG.md
file (at corresponding gem). For the description entry, please make sure it lives in one line and starts withFeature
orIssue
in the correct format.For generated code changes, please checkout below instructions first:
https://github.com/aws/aws-sdk-ruby/blob/version-3/CONTRIBUTING.md
Thank you for your contribution!